Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

fix layout #2938

Merged
merged 162 commits into from
Jan 6, 2015
Merged

fix layout #2938

merged 162 commits into from
Jan 6, 2015

Conversation

chadwhitacre
Copy link
Contributor

Rough

  • header
  • footer
  • support gratipay notice
  • content pages like about pages
  • two-column things like charts and FAQ
  • profiles
  • community pages
  • all communities listing /for/

Finish

  • penny background
  • signing out fails? sign out is borked #2940
  • clean up logo + stats in header
  • figure out column story
  • Your Weekly Gift
  • sub nav
  • root out slug == none
  • clean up sign-in/you-are area

Finish Finish

  • min height (no empty space below footer)
  • refactor SCSS
  • harmonize markup/scss between homepage and inside pages
  • clean up error pages
  • clean up Giving
  • clean up Receiving
  • clean up History
  • clean up Account
  • clean up Events
  • clean up elsewhere profiles
  • clean up elsewhere teams
  • fix that gosh darn "Sign Out" button in the #header
  • notifications
  • "upgrade browser" notice
  • cross-browser review

Finish Finish Finish

  • i18n review
  • credit card & bank account forms
  • make giving widget in sidebar AWESOME okay
  • join/leave sidebar on community pages
  • responsiveness
  • cross-browser review

Punchlist

  • "return" doesn't work from inside the your-tip <input>
  • padding is off in your-tip <input>, if I select with the mouse and go down then the text shifts

@chadwhitacre
Copy link
Contributor Author

screen shot 2014-11-14 at 11 02 39 am

@chadwhitacre
Copy link
Contributor Author

screen shot 2014-11-14 at 12 18 31 pm

@chadwhitacre
Copy link
Contributor Author

screen shot 2014-11-14 at 2 11 39 pm

@chadwhitacre
Copy link
Contributor Author

screen shot 2014-11-14 at 3 25 32 pm

screen shot 2014-11-14 at 3 25 38 pm

@chadwhitacre
Copy link
Contributor Author

screen shot 2014-11-14 at 4 24 47 pm

@chadwhitacre
Copy link
Contributor Author

All for now, will work on finish work next chance I get.

@webmaven
Copy link
Contributor

When did this get started?

@kaguillera
Copy link
Contributor

One of these are related to #2746 which I am working on. It is currently a stalled PR. I intend to work on that tomorrow.

@kaguillera kaguillera closed this Nov 14, 2014
@clone1018
Copy link
Contributor

@kaguillera Why did you close this?

@kaguillera
Copy link
Contributor

Sorry clocked wrong button

On Nov 14, 2014, at 7:27 PM, Luke Strickland [email protected] wrote:

@kaguillera Why did you close this?

—
Reply to this email directly or view it on GitHub.

@kaguillera kaguillera reopened this Nov 15, 2014
@chadwhitacre
Copy link
Contributor Author

When did this get started?

About half an hour before I opened this PR? :-)

@chadwhitacre
Copy link
Contributor Author

Prior attempt: #2769 / #2770.

@chadwhitacre chadwhitacre force-pushed the fix-layout branch 2 times, most recently from e37a36d to b5992d0 Compare November 16, 2014 03:54
@chadwhitacre
Copy link
Contributor Author

The green is a hover state. The brown is the selected state. Explore is the communities listing, and /for/ now redirects to /explore/.

screen shot 2014-11-17 at 12 04 07 pm

@techtonik
Copy link
Contributor

Selected state looks weird. I'd just let people click the logo to go to the front page for Explore and About links.

@chadwhitacre
Copy link
Contributor Author

Current status:

screen shot 2014-11-17 at 3 30 26 pm

@chadwhitacre chadwhitacre force-pushed the fix-layout branch 2 times, most recently from 79f20ef to 3fd1b09 Compare November 17, 2014 22:44
@techtonik
Copy link
Contributor

👍

@chadwhitacre
Copy link
Contributor Author

screen shot 2014-11-17 at 10 54 24 pm

screen shot 2014-11-17 at 10 57 52 pm

@clone1018
Copy link
Contributor

Love the new subnav, what happened to the right side of the profile?

What's the purpose of the extra spacing on the left side of your username at the top nav?

@chadwhitacre
Copy link
Contributor Author

Explore should eventually include Teams in addition to communities (#1483). It should also include search (#469; search should be in the header bar and land at /explore/search?q=foo).

@chadwhitacre chadwhitacre mentioned this pull request Nov 18, 2014
Closed
@chadwhitacre
Copy link
Contributor Author

IRC

@chadwhitacre @Changaco
Prune dead file
10c8490
@chadwhitacre @Changaco
Standardize on no _underscore.scss
e70a096 
There's a convention in the Sass community to prefix partials with
underscore. It's actually more than a convention, because:

`scss --watch dirname`

will produce a css file for every scss file it finds *unless* the
filename starts with underscore. Because we're not using this method of
compiling scss (we programmatically compile our scss from a simplate),
we don't need to worry about this. Let's skip the underscores.
@chadwhitacre @Changaco
Afaict the modal code was not used anywhere
3200770
@chadwhitacre
Copy link
Contributor Author

This PR is already too big, please don't hold it over details, merge it and make another PR to reorganize the SCSS.

Yeah, sorry. If this PR goes out as it is now, I'm going to be really embarrassed about how bad it is on mobile (I don't see the problems as just "details"), and I feel like we're reaching a point where making it not suck on mobile requires some refactoring. :-/

@chadwhitacre
Copy link
Contributor Author

Over the 4 years we have slowly moved away from device specific breakpoints in favour of content specific breakpoints, i.e. adding a breakpoint when the content is no longer easy to consume.

http://responsivedesign.is/articles/why-you-dont-need-device-specific-breakpoints

@chadwhitacre
Copy link
Contributor Author

  • Pick major breakpoints by starting small, then working up
  • Pick minor breakpoints when necessary
  • Optimize text for reading
  • Never completely hide content

https://developers.google.com/web/fundamentals/layouts/rwd-fundamentals/how-to-choose-breakpoints

@Changaco
Copy link
Contributor

Changaco commented Jan 6, 2015

Yeah, sorry. If this PR goes out as it is now, I'm going to be really embarrassed about how bad it is on mobile (I don't see the problems as just "details")

A few pixels out of place is definitely a detail, what I'm embarrassed about is the other 370 open issues we have. More specifically #469 is what I've been working on, and I can't fix it until this PR is merged. #2809 is also blocked, as is almost every other issue or PR that needs to modify the UI.

I feel like we're reaching a point where making it not suck on mobile requires some refactoring. :-/

There was no need to refactor anything in order to fix the Explore page.

@techtonik
Copy link
Contributor

Is there a list of pages to review? Can we generate complete sitemap without missing teeth?

@chadwhitacre chadwhitacre mentioned this pull request Jan 6, 2015
Closed
@chadwhitacre
Copy link
Contributor Author

A few pixels out of place is definitely a detail
There was no need to refactor anything in order to fix the Explore page.

We're looking at different things. I am seeing way more than a few pixels out of place on the Explore page.

More specifically #469 is what I've been working on, and I can't fix it until this PR is merged. #2809 is also blocked, as is almost every other issue or PR that needs to modify the UI.

Fair enough. After diving in a bit on a refactor I admit that it's too much to add to this PR. I've started a new PR with my initial refactoring commits from last night, and have force-pushed those commits off of this branch. Go ahead and merge this when you're ready and I'll pick up on #3063.

@chadwhitacre
Copy link
Contributor Author

Is there a list of pages to review? Can we generate complete sitemap without missing teeth?

$ find www -name \*.spt

@Changaco
fix initial team balance on Members page
41f732f 
This was broken a while back, it's not related to this PR but I'm putting the fix here while I'm at it.
@Changaco
Copy link
Contributor

Changaco commented Jan 6, 2015

Did a final visual review and sneaked in a fix for a small bug unrelated to this PR. Merging.

Changaco added a commit that referenced this pull request Jan 6, 2015
@Changaco
Merge pull request #2938 from gratipay/fix-layout
d71e38b 
fix layout
@Changaco Changaco merged commit d71e38b into master Jan 6, 2015
@Changaco Changaco deleted the fix-layout branch January 6, 2015 17:07
This was referenced Jan 6, 2015
Merged
Merged
Changaco added a commit that referenced this pull request Jan 9, 2015
@Changaco
adapt to the changes from #2938
5803b8f
Changaco added a commit that referenced this pull request Jan 10, 2015
@Changaco
adapt to the changes from #2938
0ca2852
@chadwhitacre chadwhitacre mentioned this pull request Jan 10, 2015
Closed
Changaco added a commit that referenced this pull request Feb 9, 2015
@Changaco
adapt to the changes from #2938
6132957
Changaco added a commit that referenced this pull request Feb 10, 2015
@Changaco
adapt to the changes from #2938
584c1b8
Changaco added a commit that referenced this pull request Feb 16, 2015
@Changaco
adapt to the changes from #2938
c2beab8
@chadwhitacre chadwhitacre mentioned this pull request Mar 6, 2015
Closed
4 tasks
This was referenced Mar 16, 2015
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
Redesign
Development

Successfully merging this pull request may close these issues.
7 participants
@chadwhitacre @webmaven @kaguillera @clone1018 @techtonik @rohitpaulk @Changaco