Settle whole tip graph (payday)

[rohitpaulk]

fixes #2664

[Changaco]

Not bad, but to settle the whole graph you also need to run the tips loop after the takes have been distributed. Also I don't understand what that discovered column is.

[rohitpaulk]

Not bad, but to settle the whole graph you also need to run the tips loop after the takes have been distributed.

True. Which makes me think - The second UPDATE statement should be run as a loop too.

Also I don't understand what that discovered column is.

The discovered column is an attempt to improve performance by reducing the number of times the process_tip() function runs. I try to follow the flow of money - starting from people with credit cards attached. Each person they send a tip to, is marked as discovered. After that, the is_funded update is done only on people who are discovered. Again, each person who receives a tip is marked as discovered and the loop runs again. If it weren't for this we'd be trying to update is_funded every time on people who are far far down the line, which would result in process_tip() being called unnecessarily in cases where we know for sure that is_funded is not going to change to true.

I don't know how much this will affect performance, and I guess it could be done away with for the sake of simplicity.

What do you think @Changaco ?

[Changaco]

I think you should remove discovered. I also think the tip loop should be a function that we EXECUTE before and after takes.

[Changaco]

Ping @rohitpaulk.

[rohitpaulk]

@Changaco - I saw this, looks good to me. Didn't want to merge coz it's my own PR. If you signal green on this, let's merge it in.

[Changaco]

@rohitpaulk You started the PR but your commits have already been reviewed, so you could have merged it after reviewing my commits. Or you could have just said "looks good to me" and I would have merged, but if you don't say anything I can't know that you've already reviewed the commits.

[rohitpaulk]

@Changaco - True, will keep that in mind :)

[chadwhitacre]

!m @rohitpaulk @Changaco