Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Add coinbase payin support #2841

Closed
wants to merge 6 commits into from
Closed

Add coinbase payin support #2841

wants to merge 6 commits into from

Conversation

rohitpaulk
Copy link
Contributor

Work in progess.

This is a redo of #2053

This pull request is too big. Gittip can only chew things in small bites. We need to break this up into smaller PRs.

  • Add UI to link coinbase account
  • Store coinbase result in DB
  • Set is_funded correctly by including last_coinbase_result too in participant.py.
  • Same as above, in fake_payday.sql
  • What are the fees for coinbase transactions?
  • Modify payday to first try a credit card, and then a coinbase account if that fails. If Add a funding rules UI #2299 lands before this, this will have to include changes from there.
  • Modify the missing credit card warnings to display coinbase as an option.
  • Update docs/about/faq wherever needed.

@chadwhitacre
Copy link
Contributor

Thanks for taking the initiative on this, @rohitpaulk. We need to decide whether we're going to use Balanced's Coinbase integration, or use Coinbase directly. I'm inclined towards the latter, but we should tease out the implications of both options and make a decision.

@rohitpaulk
Copy link
Contributor Author

@whit537 - I saw #2053 still open, so assumed that we'd decided to go the balanced+coinbase way.

Let's discuss this on IRC sometime and we'll make a final decision :)

@rohitpaulk
Copy link
Contributor Author

IRC

@rohitpaulk
Copy link
Contributor Author

From balanced support via email:

Sorry for the delay. I'm checking on the pricing with Matin our CEO now.

@rohitpaulk
Copy link
Contributor Author

Okay, fees confirmed.

It'll be 1% only, not 1% + 15¢.

@techtonik
Copy link
Contributor

Is there a table of all fees on incoming/outgoing flow?

I thought that https://gratipay.com/about/pricing is about price of money move and donation (more like the price you pay for receiving/donating money), but it is just about Gratipay asking for money.

@rohitpaulk
Copy link
Contributor Author

@techtonik
Copy link
Contributor

@rohitpaulk thanks, just what I need. And yes, this request is too big. =)

@chadwhitacre chadwhitacre force-pushed the master branch 2 times, most recently from bb509d8 to 0d20225 Compare November 3, 2014 21:49
@chadwhitacre
Copy link
Contributor

@seanlinsley
Copy link
Contributor

It doesn't look like this has been worked in a while, so I'm marking it as stalled.

@rohitpaulk
Copy link
Contributor Author

I'd like to work on this, but I'll need help on integrating the coinbase calls into payday. #2914 was a step in this direction, I'm not sure what's next.

cc: @Changaco

@Changaco Changaco force-pushed the add-coinbase-payin branch from 57d7dc3 to 9a01298 Compare January 3, 2015 09:18
@Changaco
Copy link
Contributor

Changaco commented Jan 3, 2015

I didn't know this was waiting for me. This PR has the same problems as #2824. We don't want to keep adding columns like last_coinbase_result to participants. We need to generalize the code to handle any number of payment methods. I already have a local branch for that but I haven't done much work on it yet.

@techtonik
Copy link
Contributor

We don't want to keep adding columns like last_coinbase_result to
participants.

Does anybody use tools to see (or dump) the current structure of DB
visually? Some time ago looked for some command line tool that outputs into
.png in a predictable way, but didn't find any that worked for me.

@Changaco Changaco mentioned this pull request Jan 3, 2015
@rohitpaulk
Copy link
Contributor Author

I didn't know this was waiting for me.

That's my fault, I should've asked you once more after we implemented #2914.

We need to generalize the code to handle any number of payment methods.

Yes, that makes sense.

@rohitpaulk
Copy link
Contributor Author

Closing this (#3245).

@rohitpaulk rohitpaulk closed this Mar 15, 2015
@Changaco Changaco deleted the add-coinbase-payin branch April 10, 2015 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants