Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] joint_buying_base : refactor #69

Conversation

legalsylvain
Copy link
Member

model joint.buying.tour.line : start_hour and arrival_hour are now computed on the fly, to avoid timezone errors model joint.buying.tour.line : add start_date and arrival_date, stored field.
minor refactor

@legalsylvain legalsylvain force-pushed the 12.0-REF-joint_buying_base-replace-time-by-datetime-in-tour branch 2 times, most recently from aaff594 to cd1882d Compare October 19, 2023 16:22
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #69 (ad47ce0) into 12.0 (0df7830) will increase coverage by 0.14%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             12.0      #69      +/-   ##
==========================================
+ Coverage   87.86%   88.01%   +0.14%     
==========================================
  Files          79       79              
  Lines        2241     2244       +3     
  Branches      387      387              
==========================================
+ Hits         1969     1975       +6     
+ Misses        215      213       -2     
+ Partials       57       56       -1     
Files Coverage Δ
joint_buying_base/models/joint_buying_tour_line.py 78.57% <100.00%> (+3.57%) ⬆️
...uying_base/wizards/joint_buying_wizard_set_tour.py 63.88% <ø> (-0.98%) ⬇️
joint_buying_base/models/joint_buying_tour.py 84.10% <90.00%> (+1.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@legalsylvain legalsylvain force-pushed the 12.0-REF-joint_buying_base-replace-time-by-datetime-in-tour branch from cd1882d to f0716a1 Compare October 19, 2023 16:31
model joint.buying.tour.line : start_hour and arrival_hour are now computed on the fly, to avoid timezone errors
model joint.buying.tour.line : add start_date and arrival_date, stored field.
minor refactor
@legalsylvain legalsylvain force-pushed the 12.0-REF-joint_buying_base-replace-time-by-datetime-in-tour branch from f0716a1 to ad47ce0 Compare October 22, 2023 20:41
@legalsylvain
Copy link
Member Author

superseded by #76 to be compatible with #68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant