Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 359 add joint buying product transport request #68

Conversation

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (465abe6) 87.86% compared to head (e1ef117) 90.53%.

Files Patch % Lines
joint_buying_base/models/joint_buying_tour.py 88.88% 6 Missing and 1 partial ⚠️
joint_buying_base/models/joint_buying_tour_line.py 73.07% 7 Missing ⚠️
...ying_base/models/joint_buying_transport_request.py 94.96% 7 Missing ⚠️
...ying_product/models/joint_buying_purchase_order.py 73.07% 7 Missing ⚠️
joint_buying_base/models/res_company.py 50.00% 2 Missing and 2 partials ⚠️
joint_buying_product/models/product_product.py 33.33% 2 Missing ⚠️
...ds/joint_buying_create_transport_request_wizard.py 92.85% 1 Missing and 1 partial ⚠️
...ing_base/wizards/joint_buying_wizard_find_route.py 99.00% 0 Missing and 1 partial ⚠️
joint_buying_product/uninstall_hook.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             12.0      #68      +/-   ##
==========================================
+ Coverage   87.86%   90.53%   +2.66%     
==========================================
  Files          79      103      +24     
  Lines        2241     3073     +832     
  Branches      387      528     +141     
==========================================
+ Hits         1969     2782     +813     
- Misses        215      235      +20     
+ Partials       57       56       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legalsylvain legalsylvain marked this pull request as draft October 18, 2023 20:05
@legalsylvain legalsylvain force-pushed the 12.0-359-ADD-joint_buying_product-transport-request branch from 5748236 to aff9e34 Compare October 24, 2023 20:35
@legalsylvain
Copy link
Member Author

Depends on #69

@legalsylvain legalsylvain force-pushed the 12.0-359-ADD-joint_buying_product-transport-request branch 20 times, most recently from 054355a to cfc5b19 Compare October 31, 2023 11:21
@legalsylvain legalsylvain force-pushed the 12.0-359-ADD-joint_buying_product-transport-request branch 4 times, most recently from e475de6 to 0472349 Compare November 1, 2023 21:35
@legalsylvain legalsylvain force-pushed the 12.0-359-ADD-joint_buying_product-transport-request branch from 0472349 to 8764760 Compare November 20, 2023 11:17
…ate transport requests, when tour is changed
…th the name of the item that generated the request. (manual / SOxxx / GPOxxx / ...)
…hase order grouped should invalidate related transport requests
…nto many lines, because of different categories
@legalsylvain legalsylvain force-pushed the 12.0-359-ADD-joint_buying_product-transport-request branch from 30563fa to e1ef117 Compare December 3, 2023 22:50
@legalsylvain legalsylvain marked this pull request as ready for review December 3, 2023 22:50
@legalsylvain
Copy link
Member Author

MeP du 3/12/2023
/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-68-by-legalsylvain-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit eb27f08 into grap:12.0 Dec 3, 2023
4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at ea6ec67. Thanks a lot for contributing to grap. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants