Skip to content

Commit

Permalink
fix(docs): Make sure helm Grafana example works as expected. (#3753) (#…
Browse files Browse the repository at this point in the history
…3754)

The problem with the grafana helm is that we don't have the profiling
port exposed as part of the containerPorts of the container. So I had to
reuse/abuse the gossip-tcp port in order to get it to be scraped.

It also was using the wrong annotation of "pyroscope.grafana.com"
instead of "profiles.grafana.com".

Fixes #3523

(cherry picked from commit 6045daa)

Co-authored-by: Christian Simon <[email protected]>
  • Loading branch information
github-actions[bot] and simonswine authored Dec 10, 2024
1 parent 96a1350 commit 8e6d43c
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions docs/sources/deploy-kubernetes/helm.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,13 @@ Use a custom namespace so that you don't have to overwrite the default namespace
--set env.GF_AUTH_ANONYMOUS_ORG_ROLE=Admin \
--set env.GF_DIAGNOSTICS_PROFILING_ENABLED=true \
--set env.GF_DIAGNOSTICS_PROFILING_ADDR=0.0.0.0 \
--set env.GF_DIAGNOSTICS_PROFILING_PORT=6060 \
--set-string 'podAnnotations.pyroscope\.grafana\.com/scrape=true' \
--set-string 'podAnnotations.pyroscope\.grafana\.com/port=6060'
--set env.GF_DIAGNOSTICS_PROFILING_PORT=9094 \
--set-string 'podAnnotations.profiles\.grafana\.com/cpu\.scrape=true' \
--set-string 'podAnnotations.profiles\.grafana\.com/cpu\.port=9094' \
--set-string 'podAnnotations.profiles\.grafana\.com/memory\.scrape=true' \
--set-string 'podAnnotations.profiles\.grafana\.com/memory\.port=9094' \
--set-string 'podAnnotations.profiles\.grafana\.com/goroutine\.scrape=true' \
--set-string 'podAnnotations.profiles\.grafana\.com/goroutine\.port=9094'
```

For details, see [Deploy Grafana on Kubernetes](/docs/grafana/latest/setup-grafana/installation/kubernetes/).
Expand Down

0 comments on commit 8e6d43c

Please sign in to comment.