Helm: Ability to change loki-read and loki-write services to NodePort #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
type/docs
| @@ -143,3 +143,5 @@ If you would like to add your organization to the list, please open a PR to add | |||
| ## License | |||
|
|
|||
| Grafana Loki is distributed under [AGPL-3.0-only](LICENSE). For Apache-2.0 exceptions, see [LICENSING.md](LICENSING.md). | |||
|
|
|||
| # changes | |||
There was a problem hiding this comment.
This entry should not be here. Changes should be added to the CHANGELOG
|
@karlkeppner1 Can you add a HELM changelog entry and update the Helm chart version to 5.5.8? An example can be found here. |
8 tasks
added 3 commits
January 29, 2024 11:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When deployed to AWS EKS, services must be of type
NodePortifingressClassName: alb. By adding the ability to specify service type for the loki-read and loki-write services, EKS users can now use the chart without loki-gateway. Added ability to specify aclusterIPif servicetype: ClusterIP. Added ability to specify annotations for each service.Which issue(s) this PR fixes:
I never raised an issue for this. I needed it personally, so I wrote it.
Special notes for your reviewer:
Previous defaults were added explicitly in values.yaml to maintain backwards compatibility.