Allow to change loki read and write service components in helm configuration #11510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When deploying to AWS EKS, services must be of type
NodePort
ifingressClassName: alb
. By adding the ability to specify service type for the lokiread
andwrite
services, EKS users can now use the chart without the loki gateway.This PR also adds the ability to specify a
clusterIP
if service type is defined asClusterIP
.This PR also adds the ability to specify annotations for each service.
Which issue(s) this PR fixes:
No issue, but this PR is based upon #9077, which was created earlier in 2023 but OP never followed up.
Special notes for your reviewer:
Previous defaults were added explicitly in values.yaml to maintain backwards compatibility.
I also had to add
.PHONY: sources/setup/install/helm/reference.md
in the Makefile in order to be able to runmake sources/setup/install/helm/reference.md
, otherwise make would interpret the input as a file to check and would returnmake: 'sources/setup/install/helm/reference.md' is up to date
. How is that makefile supposed to be used?I reviewed the contributing guidelines, including the section about contributing to docs, but it doesn't mention helm: I tried running
make docs
but it only builds the hugo docs website (btw I also had to add:z
to all volume mounts because I'm running podman on a OS with selinux).Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR