Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change loki read and write service components in helm configuration #11510

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bebosudo
Copy link
Contributor

What this PR does / why we need it:
When deploying to AWS EKS, services must be of type NodePort if ingressClassName: alb. By adding the ability to specify service type for the loki read and write services, EKS users can now use the chart without the loki gateway.
This PR also adds the ability to specify a clusterIP if service type is defined as ClusterIP.
This PR also adds the ability to specify annotations for each service.

Which issue(s) this PR fixes:
No issue, but this PR is based upon #9077, which was created earlier in 2023 but OP never followed up.

Special notes for your reviewer:
Previous defaults were added explicitly in values.yaml to maintain backwards compatibility.

I also had to add .PHONY: sources/setup/install/helm/reference.md in the Makefile in order to be able to run make sources/setup/install/helm/reference.md, otherwise make would interpret the input as a file to check and would return make: 'sources/setup/install/helm/reference.md' is up to date. How is that makefile supposed to be used?
I reviewed the contributing guidelines, including the section about contributing to docs, but it doesn't mention helm: I tried running make docs but it only builds the hugo docs website (btw I also had to add :z to all volume mounts because I'm running podman on a OS with selinux).

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@bebosudo bebosudo requested a review from a team as a code owner December 18, 2023 10:48
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Dec 18, 2023
Copy link
Contributor

Trivy scan found the following vulnerabilities:

  • HIGH, Target: docker.io/grafana/loki:main-724a841 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libcrypto3 v3.1.3-r0. Fixed in v3.1.4-r0
  • HIGH, Target: docker.io/grafana/loki:main-724a841 (alpine 3.18.4), Type: alpine openssl: Incorrect cipher key and IV length processing in libssl3 v3.1.3-r0. Fixed in v3.1.4-r0
    \nTo see more details on these vulnerabilities, and how/where to fix them, please run docker build -t grafana/loki:main-724a841 -f cmd/loki/Dockerfile .
    trivy i grafana/loki:main-724a841 on your branch. If these were not introduced by your PR, please considering fixing them in via a subsequent PR. Thanks!

@bebosudo
Copy link
Contributor Author

bebosudo commented Jul 22, 2024

Hey, any chance we could get a review on this? It would help keeping aligned with upstream upgrades 🙂

Nevermind, we moved to loki gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants