Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Document approx_topk keyword. #15179

Merged
merged 4 commits into from
Dec 10, 2024
Merged

chore: Document approx_topk keyword. #15179

merged 4 commits into from
Dec 10, 2024

Conversation

jeschkies
Copy link
Contributor

What this PR does / why we need it:
This is a follow up #14243 and documents the new approx_topk query function.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jeschkies jeschkies requested a review from a team as a code owner November 28, 2024 14:49
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 28, 2024
@jeschkies jeschkies requested a review from JStickler November 28, 2024 14:50
JStickler
JStickler reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team]

docs/sources/query/metric_queries.md Outdated Show resolved Hide resolved
docs/sources/query/metric_queries.md Outdated Show resolved Hide resolved
@jeschkies jeschkies requested a review from JStickler December 10, 2024 11:02
JStickler
JStickler approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Dec 10, 2024

This PR must be merged before a backport PR will be created.

@JStickler JStickler merged commit f17ec74 into grafana:main Dec 10, 2024
61 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Dec 10, 2024
@jeschkies @grafana-delivery-bot
chore: Document approx_topk keyword. (#15179)
11b03a9 
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit f17ec74)
@loki-gh-app loki-gh-app bot mentioned this pull request Dec 10, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler approved these changes

Assignees
No one assigned
Labels
backport release-3.3.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeschkies @JStickler