Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blooms): Add task timining and sizing metrics #15032

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:

This PR adds observability around the time it takes tasks to complete as well as metrics for the amount of data the tasks will process.

We also refactor the planning strategy factory from a function into a struct. This is needed so we don't need to recreate the metrics.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts marked this pull request as ready for review November 20, 2024 11:20
@salvacorts salvacorts requested a review from a team as a code owner November 20, 2024 11:20
@salvacorts salvacorts merged commit 79cccfd into main Nov 20, 2024
57 checks passed
@salvacorts salvacorts deleted the salvacorts/task-size-timing-metrics branch November 20, 2024 11:29
@salvacorts salvacorts added type/enhancement Something existing could be improved backport k229 labels Nov 20, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Nov 20, 2024

Hello @salvacorts!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@salvacorts salvacorts added type/bug Somehing is not working as expected backport k229 and removed type/enhancement Something existing could be improved backport k229 labels Nov 20, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k229 size/L type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants