Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use loki comntant for metrics namespace #15034

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:

Followup to #15032

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts force-pushed the salvacorts/use-loki-constant branch from 84b77c5 to 973d68f Compare November 20, 2024 12:59
@salvacorts salvacorts marked this pull request as ready for review November 20, 2024 13:00
@salvacorts salvacorts requested a review from a team as a code owner November 20, 2024 13:00
@salvacorts salvacorts merged commit 6c0f608 into main Nov 20, 2024
57 checks passed
@salvacorts salvacorts deleted the salvacorts/use-loki-constant branch November 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants