Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix helm lint #15001

Merged
merged 13 commits into from
Nov 19, 2024
Merged

ci: fix helm lint #15001

merged 13 commits into from
Nov 19, 2024

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Nov 18, 2024

What this PR does / why we need it:

Try the latest version of the super-linter to see if it fixes the broken helm linting. This PR is the same as #15000 but from a fork, as that's when we usually see errors.

Temporary fix for #14835, but long term fix is likely making GHCR pushes work: grafana/helm-charts#3068 (comment)

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney requested a review from a team as a code owner November 18, 2024 23:15
@trevorwhitney trevorwhitney changed the title Fix helm lint ci: fix helm lint Nov 18, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 19, 2024
@trevorwhitney trevorwhitney merged commit 5f50003 into grafana:main Nov 19, 2024
61 checks passed
trevorwhitney added a commit that referenced this pull request Nov 19, 2024
thevops pushed a commit to thevops/loki that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants