Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm/loki): Update helm CI workflow to fetch full history and PR ref #15011

Closed

Conversation

site0801
Copy link
Contributor

What this PR does / why we need it:
I confirmed that super-linter at #14838 is not able to ref the commit sha of PRs by external Contributors.
Therefore, in this PR, I will include the target branch in the checkout before executing super-linter.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@site0801
Copy link
Contributor Author

@trevorwhitney fixed it on #15001!
This PR seems unnecessary, so I'll close it.

@site0801 site0801 closed this Nov 19, 2024
@trevorwhitney
Copy link
Collaborator

ahh, thank you for the fix anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants