-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added Simple Scalable Deployment guide for AWS #14327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Jayclifford345 ! 🎉
Left some comments and suggestions. 😄
docs/sources/setup/install/helm/install-microservices/_index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Jay! Just a few small comments.
docs/sources/setup/install/helm/install-microservices/_index.md
Outdated
Show resolved
Hide resolved
```bash | ||
aws s3api create-bucket --bucket loki-aws-bucket --region eu-west-2 --create-bucket-configuration LocationConstraint=eu-west-2 | ||
``` | ||
Make sure to replace the region and bucket name with your desired values. We will revisit the bucket policy later in this guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and reiterating, making sure the values used in this doc are claimed by Grafana Labs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work Jay, thanks a lot!
Minor comments to clarify examples.
docs/sources/setup/install/helm/install-microservices/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/install-microservices/_index.md
Outdated
Show resolved
Hide resolved
```bash | ||
aws s3api create-bucket --bucket loki-aws-bucket --region eu-west-2 --create-bucket-configuration LocationConstraint=eu-west-2 | ||
``` | ||
Make sure to replace the region and bucket name with your desired values. We will revisit the bucket policy later in this guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 I added a suggestion above.
docs/sources/setup/install/helm/install-microservices/_index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Poyzan <[email protected]>
Hey @tomglenn, @poyzannur, @trevorwhitney thank you ever so much for the technical reviews. That should be all of your suggestions added. I shall let @JStickler give it the full docs review next and see where we are at. Then I can start filming the video |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great PR. Some minor things found but overall a massive improvement/contribution to what's there
docs/sources/setup/install/helm/install-microservices/_index.md
Outdated
Show resolved
Hide resolved
Great improvement on the docs. Once I found this PR, I was quickly able to deploy Loki in SimpleScalable mode 👍🏻 |
Co-authored-by: Jens Horstmann <[email protected]>
Hi all, after an internal discussion I am closing this PR and opened this one instead #14517 . This was after an internal discussion that we felt it was better to focus the deployment guide on distributed (microservice) and Monolithic deployments of the Loki helm. Let me know what you think of the changes in the other PR if you get chance! |
This PR adds a guide to deploying the official Loki helm to AWS in Simple Scalable. It is worth noting that there are lot of AWS specific commands within this guide. This is hard to escape due to the nature of how Loki is deployed to AWS. I have added cavitates throughout the guide to help reduce the support burden on AWS-specific questions.
I am open to removing these sections but feel the guide would be insufficient for a user attempting to deploy Loki on AWS.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR