-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Deploy Loki Helm on AWS guide #14517
Conversation
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Tom Glenn <[email protected]>
Co-authored-by: Poyzan <[email protected]>
Co-authored-by: Jens Horstmann <[email protected]>
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] As always, I spotted a few more small things. =)
docs/sources/setup/install/helm/install-microservices/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/install-microservices/_index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: J Stickler <[email protected]>
Hi @JStickler,
Other than that I belive I manged to batch add ;) all of the other fixes. Ready for your review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{docs team] LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14517-to-release-3.1.x origin/release-3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 4e4d4a962e9d1486b456693a4e951641e3ec6b3a When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14517-to-release-3.1.x
# Create the PR body template
PR_BODY=$(gh pr view 14517 --json body --template 'Backport 4e4d4a962e9d1486b456693a4e951641e3ec6b3a from #14517{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'docs: Deploy Loki Helm on AWS guide (backport release-3.1.x)' --body-file - --label 'size/XXL' --label 'type/docs' --label 'backport' --base release-3.1.x --milestone release-3.1.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14517-to-release-3.1.x
# Create a pull request where the `base` branch is `release-3.1.x` and the `compare`/`head` branch is `backport-14517-to-release-3.1.x`.
# Remove the local backport branch
git switch main
git branch -D backport-14517-to-release-3.1.x |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14517-to-release-3.2.x origin/release-3.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 4e4d4a962e9d1486b456693a4e951641e3ec6b3a When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14517-to-release-3.2.x
# Create the PR body template
PR_BODY=$(gh pr view 14517 --json body --template 'Backport 4e4d4a962e9d1486b456693a4e951641e3ec6b3a from #14517{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'docs: Deploy Loki Helm on AWS guide (backport release-3.2.x)' --body-file - --label 'size/XXL' --label 'type/docs' --label 'backport' --base release-3.2.x --milestone release-3.2.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14517-to-release-3.2.x
# Create a pull request where the `base` branch is `release-3.2.x` and the `compare`/`head` branch is `backport-14517-to-release-3.2.x`.
# Remove the local backport branch
git switch main
git branch -D backport-14517-to-release-3.2.x |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14517-to-release-3.0.x origin/release-3.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 4e4d4a962e9d1486b456693a4e951641e3ec6b3a When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14517-to-release-3.0.x
# Create the PR body template
PR_BODY=$(gh pr view 14517 --json body --template 'Backport 4e4d4a962e9d1486b456693a4e951641e3ec6b3a from #14517{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'docs: Deploy Loki Helm on AWS guide (backport release-3.0.x)' --body-file - --label 'size/XXL' --label 'type/docs' --label 'backport' --base release-3.0.x --milestone release-3.0.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14517-to-release-3.0.x
# Create a pull request where the `base` branch is `release-3.0.x` and the `compare`/`head` branch is `backport-14517-to-release-3.0.x`.
# Remove the local backport branch
git switch main
git branch -D backport-14517-to-release-3.0.x |
Co-authored-by: Tom Glenn <[email protected]> Co-authored-by: Poyzan <[email protected]> Co-authored-by: Jens Horstmann <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 4e4d4a9)
Co-authored-by: Tom Glenn <[email protected]> Co-authored-by: Poyzan <[email protected]> Co-authored-by: Jens Horstmann <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 4e4d4a9)
Co-authored-by: Tom Glenn <[email protected]> Co-authored-by: Poyzan <[email protected]> Co-authored-by: Jens Horstmann <[email protected]> Co-authored-by: J Stickler <[email protected]> (cherry picked from commit 4e4d4a9)
Co-authored-by: Jay Clifford <[email protected]>
Co-authored-by: Jay Clifford <[email protected]>
Co-authored-by: Jay Clifford <[email protected]>
This is the successor PR to the SSD PR #14327
After an internal discussion, it was decided to focus deployment guides for helm on either Monolithic or microservice . The Loki team felt more comfortable supporting both of these deployment styles since its closer to what we deploy internally.
This PR is part of a large redesign to improve the helm documentation of Loki.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR