Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blooms jsonnet components #11984

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Feb 19, 2024

What this PR does / why we need it:
To make testing easier, we are moving these files outside the repo. We will bring them back once the feature is ready.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts marked this pull request as ready for review February 19, 2024 10:58
@salvacorts salvacorts requested a review from a team as a code owner February 19, 2024 10:58
@salvacorts salvacorts merged commit ffc61fb into main Feb 19, 2024
10 checks passed
@salvacorts salvacorts deleted the salvacorts/remove-jsonnet-blooms branch February 19, 2024 11:01
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants