-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blooms): Add jsonnet lib for bloom filter components #12429
base: main
Are you sure you want to change the base?
Conversation
7ba8cb6
to
a8cfe46
Compare
Signed-off-by: Christian Haudum <[email protected]>
a8cfe46
to
01adaef
Compare
With the release of Loki 3.1 (containing a bunch of bloom fixes 🎉) it would be great to get this merged so those of us using the loki jsonnet lib can easily test out the bloom functionality! |
containerPort.new(name='grpc', port=9095), | ||
], | ||
|
||
bloom_gateway_data_pvc:: if !$._config.use_bloom_filters || !$._config.bloom_gateway.use_local_ssd then null else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug: PVC is null if you arent using local SSDs
bloom_gateway_data_pvc:: if !$._config.use_bloom_filters || !$._config.bloom_gateway.use_local_ssd then null else | |
bloom_gateway_data_pvc:: if !$._config.use_bloom_filters || $._config.bloom_gateway.use_local_ssd then null else |
local volumeMounts = [ | ||
volumeMount.new(volumeNames[x], '/data%d' % [x]) | ||
for x in paths | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't mount the PVC when not using SSDs
local volumeMounts = [ | |
volumeMount.new(volumeNames[x], '/data%d' % [x]) | |
for x in paths | |
], | |
local volumeMounts = | |
if $._config.bloom_gateway.use_local_ssd | |
then [ | |
volumeMount.new(volumeNames[x], '/data%d' % [x]) | |
for x in paths | |
] | |
else [volumeMount.new($.bloom_gateway_data_pvc.metadata.name, '/data')], |
What this PR does / why we need it:
This PR adds the jsonnet lib for deploying bloom filter components (
bloom-compactor
for the write path,bloom-gateway
for the read path) again.Special notes for your reviewer:
This lib has been originally added with #11397, #11530, #11741 and removed with #11984.
$._config.use_bloom_filters
unless you know what you're doing and/or actively developing the feature.Example configuration: