Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement support for sitewise sql #268

Closed
wants to merge 1 commit into from
Closed

Conversation

mitchlee-amzn
Copy link
Contributor

@mitchlee-amzn mitchlee-amzn commented Dec 20, 2023

What this PR does / why we need it:
This PR extends the capabilities of the datasource plugin to support the SiteWise ExecuteQuery API, which allows customers to leverage adhoc SQL queries against their assets and properties.

Which issue(s) this PR fixes:
#267

Fixes #

Special notes for your reviewer:

@mitchlee-amzn
Copy link
Contributor Author

Note this isn't working yet, but I am getting quite a few changes here, so saving state while it compiles.

@fridgepoet
Copy link
Member

Quick summary of what I've mentioned on Slack:

  1. I would suggest that we bump the version of aws-sdk-go to v1.49.6 in a separate PR and you could put your ExecuteQuery changes on top of it. The reason is that there will be quite a few other changes along with that update, and it might be better if they didn’t take away from the focus of the ExecuteQuery PR. I’ve updated Sarah’s branch/PR with the changes needed for that update: Upgrade aws-sdk-go to v1.49.6 #266 If you’re OK with that, we’ll complete the PR description and mark it as ready.

  2. As mentioned above, I was able to base your ExecuteQuery changes on top of the bump-aws-sdk branch, and the frontend query seems to be reaching the backend.

@seb-koch
Copy link

seb-koch commented Feb 20, 2024

@mitchlee-amzn This looks very promising. We'd be happy to test the implementation as we're eager to use SQL within our ongoing customer projects with SiteWise. Thanks for your work, let us know if we can support in testing and even documenting the final use cases.

+1, please continue your great work.

@vanPhilipp
Copy link

This feature provides a lot of extra flexibility, please continue.

@CFEazeti
Copy link

This would really help us to go forward in a customer project. Looking forward to this PR being finished. 👍

@reinholdalex
Copy link

+1

1 similar comment
@rastadrian
Copy link

+1

@tracy-french
Copy link
Collaborator

Happy to see all of the interest in this feature! We are actively working on prioritizing the completion of this feature and hope to continue the work soon.

@jrgns jrgns mentioned this pull request Oct 22, 2024
6 tasks
@diehbria diehbria closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants