-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw SQL Code Editor #364
Open
jrgns
wants to merge
5
commits into
grafana:main
Choose a base branch
from
jadeit:sql-query-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Raw SQL Code Editor #364
+2,822
−2,242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgns
requested review from
kevinwcyu and
njvrzm
and removed request for
a team
October 22, 2024 21:29
hwandersman
reviewed
Oct 28, 2024
hwandersman
reviewed
Oct 28, 2024
{editorMode === QueryEditorMode.Builder && ( | ||
<VisualQueryBuilder | ||
datasource={props.datasource} | ||
query={query} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swapping between modes will keep the query as a SqlQuery
. Can consider storing the last selected query in the Builder mode to update the query when swapping between Code and Builder.
High level comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to query IOT Sitewise data using the query language
This was previously attempted in #268 and allows users to use SQL to query data instead of the query builder. Using SQL allows for richer, customized queries that can combine data from multiple sources to be combined and presented in Grafana panels.
The UI when editing a panel. This shows a line graph of the returned data:
Notice the buttons in the header of the query, next to
Run queries
where the user can switch between the Builder (orinal) and Code (new).The screenshot below shows the same information, but shows the raw data instead of the line graph:
And lastly the query and returned data in the Explorer view:
Delivery items
See jadeit#1 for