Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade yaml package #249

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Upgrade yaml package #249

merged 1 commit into from
Nov 9, 2023

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet commented Nov 8, 2023 •
edited
Loading

What this PR does / why we need it:
This PR upgrades cspell, fork-ts-checker-webpack-plugin and add cosmiconfig resolution in order to upgrade the package yaml version. The main reason the older version of yaml was used was due to a transitive dependency of an older version of cosmiconfig.

fork-ts-checker-webpack-plugin and cspell were on older versions requiring an older version of cosmiconfig.
fork-ts-checker-webpack-plugin and cspell were updated, but finally @emotion/css still used an older version of cosmiconfig. So the latest version of cosmiconfig was added to resolutions.

Which issue(s) this PR fixes:

Fixes https://github.com/grafana/oss-plugin-partnerships/issues/465

Special notes for your reviewer:
Is the following message during yarn install any issue?

Resolving packages...
warning Resolution field "[email protected]" is incompatible with requested version "cosmiconfig@^7.0.0"
warning Resolution field "[email protected]" is incompatible with requested version "[email protected]"

I sanity checked this locally and saw no issues.

Thank you Kevin and Ida for the help!

@fridgepoet fridgepoet marked this pull request as ready for review November 8, 2023 15:16
@fridgepoet fridgepoet requested a review from a team as a code owner November 8, 2023 15:16
@fridgepoet fridgepoet requested review from iwysiu and sarahzinger and removed request for a team November 8, 2023 15:16
@fridgepoet fridgepoet changed the title Upgrade cspell, fork-ts-checker-webpack-plugin and add cosmiconfig resolution Upgrade yaml package Nov 8, 2023
sarahzinger
sarahzinger approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Is the following message during yarn install any issue?"

I think my guess is it could be but its not necessarily an issue? I think if you can run it locally and seems to build fine it's probably fine?

@fridgepoet fridgepoet merged commit 46d6e02 into main Nov 9, 2023
6 checks passed
@fridgepoet fridgepoet deleted the package-yaml-upgrade branch November 9, 2023 09:02
This was referenced Nov 9, 2023
Closed
Closed
Merged
Merged
@fridgepoet
Copy link
Member Author

Sorry apparently a higher version of yaml was needed #253

@fridgepoet fridgepoet mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fridgepoet @sarahzinger