Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade underscore, d3-color, debug, cosmiconfig, yaml dependencies #263

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

fridgepoet
Copy link
Member

@fridgepoet fridgepoet commented Nov 9, 2023

What this PR does / why we need it:
This adds underscore v1.12.1 to the resolutions in package.json.
This adds d3-color v3.1.0 to the resolutions in package.json.
This adds debug v2.6.9 to the resolutions in package.json.

Similar to grafana/iot-sitewise-datasource#249

This PR upgrades cspell, fork-ts-checker-webpack-plugin and add cosmiconfig resolution in order to upgrade the package yaml version. The main reason the older version of yaml was used was due to a transitive dependency of an older version of cosmiconfig.

fork-ts-checker-webpack-plugin and cspell were on older versions requiring an older version of cosmiconfig.
fork-ts-checker-webpack-plugin and cspell were updated, but finally @emotion/css still used an older version of cosmiconfig. So the latest version of cosmiconfig was added to resolutions.

Which issue(s) this PR fixes:

Fixes https://github.com/grafana/oss-plugin-partnerships/issues/529
Fixes https://github.com/grafana/oss-plugin-partnerships/issues/527
Fixes https://github.com/grafana/oss-plugin-partnerships/issues/526
Fixes https://github.com/grafana/oss-plugin-partnerships/issues/524

Special notes for your reviewer:

@fridgepoet fridgepoet requested a review from a team as a code owner November 9, 2023 16:25
@fridgepoet fridgepoet requested review from idastambuk and kevinwcyu and removed request for a team November 9, 2023 16:25
@fridgepoet fridgepoet changed the base branch from package-d3-color-upgrade to main November 9, 2023 17:05
@fridgepoet fridgepoet changed the title Add underscore to resolutions in package.json Upgrade underscore, d3-color, debug, cosmiconfig dependencies Nov 9, 2023
@fridgepoet fridgepoet closed this Nov 9, 2023
@fridgepoet fridgepoet reopened this Nov 9, 2023
@fridgepoet fridgepoet changed the title Upgrade underscore, d3-color, debug, cosmiconfig dependencies Upgrade underscore, d3-color, debug, cosmiconfig, yaml dependencies Nov 9, 2023
@fridgepoet fridgepoet merged commit 709821c into main Nov 10, 2023
2 checks passed
@fridgepoet fridgepoet deleted the package-underscore-upgrade branch November 10, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants