Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo] Feature/add readiness and liveness probes fresh #3489

Conversation

Mistral-valaise
Copy link
Contributor

this change resolves #3188 by adding readiness and liveness probes to Tempo Helm Chart
Signed-off-by: Mistral-valaise [email protected]

Signed-off-by: Mistral-valaise <[email protected]>

Signed-off-by: Mistral Nembot <[email protected]>
Signed-off-by: Mistral-valaise <[email protected]>

Signed-off-by: Mistral Nembot <[email protected]>
@Mistral-valaise Mistral-valaise force-pushed the feature/add-readiness-and-liveness-probes-fresh branch from 5f22475 to c33f368 Compare December 13, 2024 11:30
@Mistral-valaise Mistral-valaise changed the title Feature/add readiness and liveness probes fresh [tempo] Feature/add readiness and liveness probes fresh Dec 13, 2024
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mistral-valaise could you please address the conflicts ? thanks!

@Mistral-valaise
Copy link
Contributor Author

Thank @Sheikh-Abubaker for pointing that out! 😊 I’ve resolved the conflict and adjusted the changes accordingly.
Please let me know if there are any further comments or suggestions.

@Sheikh-Abubaker
Copy link
Collaborator

Sheikh-Abubaker commented Dec 14, 2024

@Mistral-valaise please sign the DCO and address the trailing space error, thanks!

@Mistral-valaise Mistral-valaise force-pushed the feature/add-readiness-and-liveness-probes-fresh branch from 830fa6d to 461f291 Compare December 15, 2024 10:49
@Mistral-valaise Mistral-valaise force-pushed the feature/add-readiness-and-liveness-probes-fresh branch from 7edbbcb to 0b72027 Compare December 16, 2024 12:35
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sheikh-Abubaker Sheikh-Abubaker merged commit 27953cb into grafana:main Dec 16, 2024
6 checks passed
@Mistral-valaise Mistral-valaise deleted the feature/add-readiness-and-liveness-probes-fresh branch December 16, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants