-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo] feat: add readiness and liveness probe #3188
[tempo] feat: add readiness and liveness probe #3188
Conversation
22c8af4
to
2c17ffd
Compare
|
…statefulset.yaml Signed-off-by: mistralnembot <[email protected]>
…ues files Signed-off-by: mistralnembot <[email protected]>
1832853
to
3d952af
Compare
…figuration-Options-to-Tempo-Helm-Chart
…figuration-Options-to-Tempo-Helm-Chart
…figuration-Options-to-Tempo-Helm-Chart
…figuration-Options-to-Tempo-Helm-Chart
…figuration-Options-to-Tempo-Helm-Chart
What's the issue with this PR? |
i did it more than 5 months ago but unfortunately it was not reviewed. i will update the branch and validate all again |
…figuration-Options-to-Tempo-Helm-Chart
thx for the PR! can you review the linting issues? |
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Ilia Lazebnik <[email protected]>
to 0.50 Signed-off-by: drfaust92 <[email protected]>
to 0.50 Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: Costis <[email protected]>
…s` objects. There's been recent confusion over the use of the `global_overrides` and `overrides` objects. This PR aims to make it clearer. Signed-off-by: Heds Simons <[email protected]>
Signed-off-by: Robbie Lankford <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
98974ff
to
73429dc
Compare
i made the last 2 commits without signoff, since i had merged the main branch to mine afterwards, i have difficulties to validate DCO afterwards. |
Sure! you could open a new fresh PR. |
After reviewing the Grafana Tempo documentation (https://grafana.com/docs/tempo/latest/api_docs/#readiness-probe), I found that the /ready endpoint is available for readiness probes. However, there isn’t a specific endpoint designated for liveness probes. To address this, I propose using the /ready endpoint for the readiness probe and the /metrics endpoint for the liveness probe. Could you please share your thoughts on this approach? readinessProbe: |
here is my new PR #3489 |
this change resolves #3185 by adding readiness and liveness probe configuration options to tempo helm chart