Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the latency_fanout with some very unscientific values #6313

Closed
wants to merge 2 commits into from
Closed

Adjust the latency_fanout with some very unscientific values #6313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d25ed67
These are very unscientific bucket values.
mattdurham Feb 5, 2024
f44b372
These are very unscientific bucket values.
mattdurham Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ Main (unreleased)

- `service_name` label is inferred from discovery meta labels in `pyroscope.java` (@korniltsev)

- Changed default buckets for `agent_prometheus_fanout_latency` to `.005, .01, .05, .1, .5, 1, 5, 10, 60, 90, 300`s. (@mattdurham)

### Bugfixes

- Fix an issue in `remote.s3` where the exported content of an object would be an empty string if `remote.s3` failed to fully retrieve
Expand Down
5 changes: 3 additions & 2 deletions component/prometheus/fanout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ type Fanout struct {
// NewFanout creates a fanout appendable.
func NewFanout(children []storage.Appendable, componentID string, register prometheus.Registerer, ls labelstore.LabelStore) *Fanout {
wl := prometheus.NewHistogram(prometheus.HistogramOpts{
Name: "agent_prometheus_fanout_latency",
Help: "Write latency for sending to direct and indirect components",
Name: "agent_prometheus_fanout_latency",
Help: "Write latency for sending to direct and indirect components",
Buckets: []float64{.005, .01, .05, .1, .5, 1, 5, 10, 60, 90, 300},
})
_ = register.Register(wl)

Expand Down
Loading