Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the latency_fanout with some very unscientific values #6313

Closed
wants to merge 2 commits into from

Conversation

mattdurham
Copy link
Collaborator

PR Description

Which issue(s) this PR fixes

The default buckets ended at 10 seconds and the write path can take much longer than that. Chose 300s (5m) as the max since anything above that hits the staleness marker and would be a really bad indicator.

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updatedad

@mattdurham mattdurham marked this pull request as ready for review February 5, 2024 20:31
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I don't want to have to change this again after we find out we need more specific buckets. Can you ask around how we should distribute buckets for a histogram? It would be good knowledge for us to have in general going forward.

(Or is this an opportunity for us to use native histograms, even? 👀)

Copy link
Contributor

github-actions bot commented Mar 7, 2024

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Mar 7, 2024
@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Apr 12, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 20, 2024
@rfratto
Copy link
Member

rfratto commented Jun 14, 2024

I'm going to close this for now as stale. If we want to pick this back up, I think we should move the PR to the Alloy repo and then consider whether it should be backported here.

@rfratto rfratto closed this Jun 14, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Jul 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. needs-attention An issue or PR has been sitting around and needs attention. variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants