-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the latency_fanout with some very unscientific values #6313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha I don't want to have to change this again after we find out we need more specific buckets. Can you ask around how we should distribute buckets for a histogram? It would be good knowledge for us to have in general going forward.
(Or is this an opportunity for us to use native histograms, even? 👀)
This PR has not had any activity in the past 30 days, so the |
This PR has not had any activity in the past 30 days, so the |
I'm going to close this for now as stale. If we want to pick this back up, I think we should move the PR to the Alloy repo and then consider whether it should be backported here. |
PR Description
Which issue(s) this PR fixes
The default buckets ended at 10 seconds and the write path can take much longer than that. Chose 300s (5m) as the max since anything above that hits the staleness marker and would be a really bad indicator.
Notes to the Reviewer
PR Checklist