Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storm: Fix linting and helm dependency update #1

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ jobs:

- name: Run chart-testing (lint)
if: steps.list-changed.outputs.changed == 'true'
run: ct lint --config ct.yaml --target-branch ${{ github.event.repository.default_branch }} --validate-maintainers=false
run: |
# Required for Storm chart due to old version
helm repo add bitnami-full-index https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
ct lint --config ct.yaml --target-branch ${{ github.event.repository.default_branch }} --validate-maintainers=false

- name: Create kind cluster
if: steps.list-changed.outputs.changed == 'true'
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/scripts/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -155,16 +155,6 @@
},
"tests": false
},
{
"name": "armada-jobservice",
"source": "deployment/jobservice",
"destination": "armada",
"use_ref_as_version": {
"pattern": "^refs/tags/v",
"replacement": ""
},
"tests": false
},
{
"name": "armada-lookout-v2",
"source": "deployment/lookout-v2",
Expand Down
9 changes: 6 additions & 3 deletions storm/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
dependencies:
- name: zookeeper
repository: https://charts.bitnami.com/bitnami
repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
version: 6.5.4
digest: sha256:58887caf583ed996b79fd38c47155ac3257e23780df3b70134430a61cb725ba8
generated: "2021-03-27T21:30:18.691467-07:00"
- name: common
repository: oci://registry-1.docker.io/bitnamicharts
version: 2.19.0
digest: sha256:3dea41e3dd9a2337df13887a23eac20aa4164ff053a1769048f70090f0178f44
generated: "2024-03-14T12:51:15.951054+01:00"
33 changes: 19 additions & 14 deletions storm/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,24 +1,29 @@
apiVersion: v2
appVersion: 2.4.0
version: 1.2.0
version: 1.2.1
description: Apache Storm is a free and open source distributed realtime computation system.
home: http://storm.apache.org/
icon: http://storm.apache.org/images/logo.png
keywords:
- storm
- zookeeper
- storm
- zookeeper
maintainers:
- name: of13tch
- name: stackedsax
- name: mariannovotny
- name: jgiannuzzi
- name: yasram1
- name: of13tch
- name: stackedsax
- name: mariannovotny
- name: jgiannuzzi
- name: yasram1
name: storm
sources:
- https://github.com/G-Research/charts/tree/master/src/storm
- https://github.com/apache/storm
- https://github.com/G-Research/charts/tree/master/src/storm
- https://github.com/apache/storm
dependencies:
- name: zookeeper
version: ~6.5.2
repository: https://charts.bitnami.com/bitnami
condition: zookeeper.enabled
- name: zookeeper
version: ~6.5.2
repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami
condition: zookeeper.enabled
- name: common
repository: oci://registry-1.docker.io/bitnamicharts
tags:
- bitnami-common
version: 2.x.x
Binary file added storm/charts/common-2.19.0.tgz
Binary file not shown.
30 changes: 15 additions & 15 deletions storm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ nimbus:
replicaCount: 1
image:
repository: storm
tag: 2.4.0
tag: 2.4.0-temurin
pullPolicy: IfNotPresent
service:
name: nimbus
Expand All @@ -27,7 +27,7 @@ supervisor:
replicaCount: 2
image:
repository: storm
tag: 2.4.0
tag: 2.4.0-temurin
pullPolicy: IfNotPresent
service:
name: supervisor
Expand All @@ -36,10 +36,10 @@ supervisor:
resources:
requests:
cpu: 1
memory: 512 #Mi
memory: 512 # Mi
limits:
cpu: 2
memory: 1024 #Mi
memory: 1024 # Mi
nodeSelector: {}
tolerations: []
affinity: {}
Expand All @@ -52,27 +52,27 @@ supervisor:
## @param extraVolumes Optionally specify extra list of additional volumes for the Supervisor pod(s)
## Example use case:
## extraVolumes:
## - name: extra-config
## - name: extra-config
## configMap:
## name: extra-config
## name: extra-config
##
extraVolumes: []

## @param extraVolumeMounts Optionally specify extra list of additional volumeMounts for the Supervisor container(s)
## Example use case:
## extraVolumeMounts:
## - name: extra-config
## - name: extra-config
## mountPath: /opt/config
## readOnly: true
##
##
extraVolumeMounts: []

ui:
enabled: true
replicaCount: 1
image:
repository: storm
tag: 2.4.0
tag: 2.4.0-temurin
pullPolicy: IfNotPresent
service:
type: ClusterIP
Expand All @@ -92,17 +92,17 @@ persistence:
# storageClass: "-"
accessModes:
- ReadWriteOnce

data:
size: 1Gi
annotations: {}
# existingClaim:

logs:
size: 1Gi
annotations: {}
# existingClaim:

metrics:
size: 200Mi
annotations: {}
Expand All @@ -112,7 +112,7 @@ zookeeper:
enabled: true
replicaCount: 1
# # if using an external zookeeper, you need to set the server names below
# servers:
# servers:
# - "example.external.zookeeper1"
# - "example.external.zookeeper2"
# - "example.external.zookeeper3"
Expand Down Expand Up @@ -141,8 +141,8 @@ jmx:
enabled: false
config: |-
rules:
- pattern: ".*"
- pattern: ".*"

exporter:
prometheus:
enabled: true
enabled: true