Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storm: Fix linting and helm dependency update #1

Closed
wants to merge 4 commits into from

Conversation

ljubon
Copy link
Collaborator

@ljubon ljubon commented Mar 14, 2024

What type of PR is this?

This is an improvement PR

What this PR does / why we need it:

After merging G-Research#121 we found a problem with Storm chart during lint and installing process. More info in the comment

The scope of this PR is:

Acceptance criteria / Notes for the reviewer:

  • Checks are green
  • Comments are resolved
  • No issues during lint
  • No issues during installing the chart

Copy link

@pavlovic-ivan pavlovic-ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ljubon! 🚀

ljubon and others added 2 commits May 15, 2024 11:54
Co-authored-by: Daniel Skowroński <[email protected]>
Co-authored-by: Ljubo Nikolic <[email protected]>
@ljubon
Copy link
Collaborator Author

ljubon commented Jul 24, 2024

closing internal PR as it's merged upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants