User guide, shortcodes, print preview: fix broken links #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deining
force-pushed
the
output-format-print-broken-links
branch
from
56de278
to
02f7e65
Compare
chalin
reviewed
Feb 28, 2023
Yes, I consider this PR a workaround only. |
|
These link check results reveal that there definitely seems to be a problem with broken links with our print preview. |
deining
force-pushed
the
output-format-print-broken-links
branch
from
02f7e65
to
440b47d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User guide, page
Shortcodes, regular view:User guide, page
Shortcodes, print view:The link to the flag is broken in the print view. This PR address this issue and fixes it by using absolute image links.