Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print section with images in page bundles has broken image links #1348

Open
jeffu231 opened this issue Jan 8, 2023 · 4 comments
Open

Print section with images in page bundles has broken image links #1348

jeffu231 opened this issue Jan 8, 2023 · 4 comments
Milestone

Comments

@jeffu231
Copy link

jeffu231 commented Jan 8, 2023

When images are included as page bundles and the print section feature is used, the images will have broken links in the content rendered for printing. An example of this can be found in docsy's own documentation.

Navigate to: https://www.docsy.dev/docs/adding-content/shortcodes/
Scroll down and there are flag images in a section demonstrating a tab pane. One in each tab.
Use the print section function to format the page for printing.
Scroll down and note that the images in the tabbed pane are broken links. These are images in a page bundle.

The images linked from an outside CDN, or placed in something like static also work. The problem comes in the pathing to the images when page bundles are used.

@LisaFC
Copy link
Collaborator

LisaFC commented Jan 9, 2023

@gwatts (or anyone else familiar with the print layout) can you take a look at this?

@jeffu231
Copy link
Author

jeffu231 commented Apr 2, 2023

Any chance someone can look at solving this issue?

@deining
Copy link
Collaborator

deining commented Apr 2, 2023

Any chance someone can look at solving this issue?

For a workaround, see #1449.

@chalin chalin added this to the 23Q3 milestone May 31, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Jul 27, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Nov 3, 2023
@chalin chalin modified the milestones: 24Q1, 24Q2 Jan 11, 2024
@spacewander
Copy link

it seems that the links on the print page are not resolved according to their new position. The workaround is to change them into absolute paths, like what #1449 does

@chalin chalin modified the milestones: 24Q2, 24Q3 Apr 2, 2024
@chalin chalin modified the milestones: 24Q3, 24Q4 Jul 2, 2024
@chalin chalin modified the milestones: 24Q4, 25Q1 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants