📚Improve documentation - rework getting-started notebook. #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
step 1
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
|
beste joris, kan ik hier nu nog meer in editen, of moet het stap voor stap? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
=======================================
+ Coverage 88.6% 88.8% +0.1%
=======================================
Files 107 109 +2
Lines 5128 5245 +117
Branches 962 983 +21
=======================================
+ Hits 4544 4658 +114
Misses 468 468
- Partials 116 119 +3 ☔ View full report in Codecov by Sentry. |
s-weigand
previously requested changes
Sep 27, 2024
Added (temporary) installation guide Move usage notice out of README
jsnel
dismissed
s-weigand’s stale review
The requested changes were made (by me)
If they installed it already they don't need the guide :P
Slight rewording of installations instructions Added initial commit to changelog
And quickstart_project to my_project
Added plot config
Small simplification in model
jsnel
changed the title
jsnel
changed the title
jsnel
previously approved these changes
Sep 29, 2024
s-weigand
previously approved these changes
Sep 29, 2024
And more SEO optimization
|
jsnel
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor updates to the readme to better reflect where we currently stand.
@jsnel reworked the getting-started notebook, and improved the installation instructions in the docs