-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Use svd function on raw numpy arrray instead of xarray dataarray #1520
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1520 +/- ##
=======================================
+ Coverage 88.6% 88.8% +0.1%
=======================================
Files 107 109 +2
Lines 5128 5245 +117
Branches 962 982 +20
=======================================
+ Hits 4544 4658 +114
Misses 468 468
- Partials 116 119 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
This should fix an issues with numpy > 2.0.1 and should be backwards compatible.
499bb5c
to
3885447
Compare
Quality Gate passedIssues Measures |
I manually tested with both numpy 2.0.1 and numpy 1.26.4, running all examples notebooks, and observed no failing cell executions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this will enable compatibility with numpy>2
(as far as numba
also supports it) 🎉
This should fix an issues with numpy > 2.0.1 and should be backwards compatible.
Change summary
Checklist