Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Use .data attribute in add_svd_to_dataset function to fix numpy>2 issue #1522

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Aug 25, 2024

Forward port of #1520

Change summary

  • 🩹Fix prepare_dataset's add_svd_to_dataset function by using raw numpy .data array instead of xarray dataarray by to resolve an issue with numpy>2.

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

Use raw numpy array instead of xarray dataarray by accessing the dataarray's .data attribute. This resolved an issues with numpy>2.
@jsnel jsnel requested a review from a team as a code owner August 25, 2024 14:33
Copy link
Contributor

sourcery-ai bot commented Aug 25, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Contributor

Binder 👈 Launch a binder notebook on branch jsnel/pyglotaran/fix_numpy_2_issues_staging

Copy link

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.3%. Comparing base (f21ca65) to head (dcd45ed).
Report is 3 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff           @@
##           staging   #1522   +/-   ##
=======================================
  Coverage     85.3%   85.3%           
=======================================
  Files           91      91           
  Lines         3756    3756           
  Branches       734     734           
=======================================
  Hits          3205    3205           
  Misses         439     439           
  Partials       112     112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jsnel
Copy link
Member Author

jsnel commented Aug 25, 2024

All tests except Compare Results are passing. The results is unchanged w.r.t. previous PR (e.g. #1501). So this should be good to go.

Copy link
Member

@s-weigand s-weigand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-weigand s-weigand merged commit 2ef4cea into glotaran:staging Aug 25, 2024
36 of 37 checks passed
@s-weigand s-weigand deleted the fix_numpy_2_issues_staging branch August 25, 2024 14:40
jsnel added a commit to joernweissenborn/pyglotaran that referenced this pull request Sep 14, 2024
Forward port of

🩹 Fix prepare_dataset's add_svd_to_dataset function (glotaran#1522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants