-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Use .data attribute in add_svd_to_dataset function to fix numpy>2 issue #1522
Conversation
Use raw numpy array instead of xarray dataarray by accessing the dataarray's .data attribute. This resolved an issues with numpy>2.
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #1522 +/- ##
=======================================
Coverage 85.3% 85.3%
=======================================
Files 91 91
Lines 3756 3756
Branches 734 734
=======================================
Hits 3205 3205
Misses 439 439
Partials 112 112 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
All tests except Compare Results are passing. The results is unchanged w.r.t. previous PR (e.g. #1501). So this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Forward port of 🩹 Fix prepare_dataset's add_svd_to_dataset function (glotaran#1522)
Forward port of #1520
Change summary
Checklist