C++: Introduce a new base class for template parameters #18308
Conversation
jketema
force-pushed
the
template-parameters
branch
2 times, most recently
from
94e9b6e to
fda2d75
Compare
jketema
added
the
depends on internal PR
This will enable us to support non-type template parameters, which we currently do not support, and error template parameters, which might become relevant in the `build-mode: none` context.
jketema
force-pushed
the
template-parameters
branch
from
fda2d75 to
b7d1da8
Compare
| --- | ||
| category: feature | ||
| --- | ||
| * A new class `TemplateParameterBase` was introduced, which represents C++ non-type template parameters, type template parameters, and template template parameters. |
There was a problem hiding this comment.
Technically, this is currently a lie, as nothing represents non-type template parameters. I plan to fix this next.
| @@ -1695,7 +1717,7 @@ class TemplateParameter extends UserType { | |||
| * void foo(const Container<Elem> &value) { } | |||
| * ``` | |||
| */ | |||
| class TemplateTemplateParameter extends TemplateParameter { | |||
| class TemplateTemplateParameter extends TypeTemplateParameter { | |||
There was a problem hiding this comment.
Based on the description in the change note I thought that type template parameters and template template parameters where to different groups and wouldn't have expected TemplateTemplateParameter to extend TypeTemplateParameter?
There was a problem hiding this comment.
I could pull that apart, but that will have quite some fallout in other places, and possibly for customers. So, I prefer to leave this as-is. Another observation is that template template parameters will still refer to (templated) types, so from that perspective it makes sense to have this layering, I think.
There was a problem hiding this comment.
I see, thanks. Let's keep it like this then :)
cpp/ql/lib/semmle/code/cpp/Type.qll
Outdated
| * In the example below, `T` and `I` are template parameters: | ||
| * ``` | ||
| * template <class T, int I> | ||
| * class C { }; |
There was a problem hiding this comment.
Maybe it would be nice to add a template template parameter as well:
| * In the example below, `T` and `I` are template parameters: | |
| * ``` | |
| * template <class T, int I> | |
| * class C { }; | |
| * In the example below, `T`, `I`, and `V` are template parameters: | |
| * ``` | |
| * template <class T, int I, template<typename> class V> | |
| * class C { }; |
This will enable us to support non-type template parameters, which we currently do not support, and error template parameters, which might become relevant in the
build-mode: nonecontext.DCA was ran on the internal PR.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).