Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Shorten test target names to make Windows happy. #18245

Merged
merged 3 commits into from
Dec 9, 2024
Merged

C#: Shorten test target names to make Windows happy. #18245

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18560cd
C#: Shorten test target names to make Windows happy.
criemen Dec 8, 2024
526dbe5
Address review, also run semmle-util tests.
criemen Dec 9, 2024
798b86f
Disable semmle.util.tests again.
criemen Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions csharp/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ test_suite(
name = "unit-tests",
tags = ["csharp"],
tests = [
"//csharp/autobuilder/Semmle.Autobuild.CSharp.Tests",
"//csharp/autobuilder/Semmle.Autobuild.Cpp.Tests",
"//csharp/extractor/Semmle.Extraction.Tests",
"//csharp/autobuilder/Semmle.Autobuild.CSharp.Tests:t",
"//csharp/autobuilder/Semmle.Autobuild.Cpp.Tests:t",
"//csharp/extractor/Semmle.Extraction.Tests:t",
],
)
3 changes: 2 additions & 1 deletion csharp/autobuilder/Semmle.Autobuild.CSharp.Tests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ load(
)

codeql_xunit_test(
name = "Semmle.Autobuild.CSharp.Tests",
# short name as we run into long path limitations on Windows
name = "t",
srcs = glob([
"*.cs",
]),
Expand Down
3 changes: 2 additions & 1 deletion csharp/autobuilder/Semmle.Autobuild.Cpp.Tests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ load(
)

codeql_xunit_test(
name = "Semmle.Autobuild.Cpp.Tests",
# short name as we run into long path limitations on Windows
name = "t",
srcs = glob([
"*.cs",
]),
Expand Down
2 changes: 1 addition & 1 deletion csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ codeql_csharp_library(
"SourceGenerators/**/*.cs",
]),
allow_unsafe_blocks = True,
internals_visible_to = ["Semmle.Extraction.Tests"],
internals_visible_to = ["t"],
visibility = ["//csharp:__subpackages__"],
deps = [
"//csharp/extractor/Semmle.Extraction.CSharp",
Expand Down
2 changes: 1 addition & 1 deletion csharp/extractor/Semmle.Extraction.CSharp.StubGenerator/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ codeql_csharp_library(
srcs = glob([
"*.cs",
]),
internals_visible_to = ["Semmle.Extraction.Tests"],
internals_visible_to = ["t"],
visibility = ["//csharp:__subpackages__"],
deps = [
"//csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching",
Expand Down
3 changes: 2 additions & 1 deletion csharp/extractor/Semmle.Extraction.Tests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ load(
)

codeql_xunit_test(
name = "Semmle.Extraction.Tests",
# short name as we run into long path limitations on Windows
name = "t",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use different short names for each project?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Let's see if 4 characters are too much already or not.

srcs = glob([
"*.cs",
]),
Expand Down
Loading