C#: Shorten test target names to make Windows happy. #18245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criemen
force-pushed
the
criemen/csharp-win-tests
branch
from
d8aeb70 to
18560cd
Compare
michaelnebel
reviewed
Dec 9, 2024
| @@ -4,7 +4,8 @@ load( | |||
| ) | |||
|
|
|||
| codeql_xunit_test( | |||
| name = "Semmle.Extraction.Tests", | |||
| # short name as we run into long path limitations on Windows | |||
| name = "t", | |||
There was a problem hiding this comment.
Maybe use different short names for each project?
There was a problem hiding this comment.
Sure! Let's see if 4 characters are too much already or not.
criemen
force-pushed
the
criemen/csharp-win-tests
branch
from
c739f19 to
798b86f
Compare
|
It seems when I ported the test suite to Bazel, I forgot to enable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, we can finally re-enable the C# unit tests on Windows (no more bazel errors about path length limitations).
The target name appears 3/4 times in the relevant path, so shortening it from the original names to "t" fixes our long-path problem.