Rust: Count number of CFG inconsistencies #17763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
paldepind
reviewed
Oct 15, 2024
rust/ql/lib/codeql/rust/controlflow/internal/CfgConsistency.qll
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count the number of CFG inconsistencies in Rust:
rust/diagnostics/cfg-consistencywhich lists each CFG inconsistency in a database. Here I have given this query metadata and moved the logic out into a shared libraryCfgConsistency.qll.rust/diagnostics/cfg-consistency-countslists the number of inconsistencies of each type in a database.rust/summary/summary-statisticsis extended to report the total number of CFG inconsistencies (regardless of type).The intent is to add the data from the second or third of these to the DCA job, and track it as a metric. I'm leaning towards the third (i.e. just the total) because it's easier to maintain if we add further consistency checks. It does add an extra step to diagnosing any regressions, but that's an investigatory process either way.
A similar PR for AST consistency counts will follow.