Rust: Count number of AST inconsistencies #17774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o that it gets run as a diagnmetric query for DCA.
…can access data in the DCA job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #17763 but for AST inconsistencies.
rust/diagnostics/ast-consistencywhich lists each AST inconsistency in a database. Here I have given this query metadata and moved the logic out into a shared libraryAstConsistency.qll.ust/diagnostics/ast-consistency-countslists the number of inconsistencies of each type in a database.rust/summary/summary-statisticsis extended to report the total number of AST inconsistencies (regardless of type). I've also converted the query to ametricquery so that it can be accessed in the DCA job.The intent is to add the total number of AST consistencies to the DCA job, and track it as a metric.