Go: Fix build scripts running for each workspace #16704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These ensure that the module path is used automatically
mbg
force-pushed
the
mbg/go/fix/build-scripts-running-more-than-once
branch
from
2f5441b to
e7a60b7
Compare
mbg
force-pushed
the
mbg/go/fix/build-scripts-running-more-than-once
branch
from
5c1f68c to
e7a60b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in the Go autobuilder which we became aware of in #16448: if a repository contains multiple logical workspaces and a build script (such as a
Makefile), then that build script is erroneously executed for each logical workspace.The fix is mainly to only execute build scripts once, but this PR also adjusts some other, related parts of the autobuild process to ensure that they run for the correct workspace, rather than in the root of the repository.
Evaluation
I have a run a QA experiment for this PR which shows only one regression, nine progressions, and various timing improvements that we would expect to see from not running build scripts multiple times.
Further, I have tested the repository linked to in the above issue with this fix and can confirm that the build time has improved considerably while still successfully extracting all 49 modules.