Go: Prevent go.mod files from being added to every directory with stray source files
#16727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tray source files
…bg/go/fix/too-many-go-mod-files-initialised
Base automatically changed from
mbg/go/fix/build-scripts-running-more-than-once
to
main
June 11, 2024 21:23
|
The results of the QA experiment for this look good (note that they are combined with the changes from #16704). |
|
I also tested this locally on the old commit of |
owen-mc
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes another bug in the Go autobuilder which I discovered while testing the fix implemented in #16704. Specifically, for an old commit of a repository that didn't use Go modules (except for one in a deeply nested directory), the autobuilder ended up initialising
go.modfiles in every directory containing stray Go source files. This PR fixes this to only initialise them in as few directories, as far up the directory hierarchy as possible.