Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Change StringBuilder flow models to not use Element access path #15025

Merged
merged 4 commits into from
Dec 7, 2023
Merged

C#: Change StringBuilder flow models to not use Element access path #15025

merged 4 commits into from
Dec 7, 2023

Conversation

tamasvajk
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the C# label Dec 6, 2023
@tamasvajk tamasvajk mentioned this pull request Dec 6, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",25,11891,67,9
+    System,"``System.*``, ``System``",25,11890,67,9
-    Totals,,25,13009,399,9
+    Totals,,25,13008,399,9
  • Changes to framework-coverage-csharp.csv:
- System,67,25,11891,,8,8,9,,,4,5,33,1,17,3,4,9906,1985
+ System,67,25,11890,,8,8,9,,,4,5,33,1,17,3,4,9946,1944

@tamasvajk
Copy link
Contributor Author

DCA reports new findings on mono/mono, but that might just be due to wobbliness. Analysis times show general speed improvement.

@tamasvajk tamasvajk marked this pull request as ready for review December 6, 2023 19:31
@tamasvajk tamasvajk requested a review from a team as a code owner December 6, 2023 19:31
hvitved
hvitved requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise LGTM.

csharp/ql/lib/ext/System.Text.model.yml Outdated
Comment on lines 103 to 104
- ["System.Text", "StringBuilder", False, "ToString", "()", "", "Argument[this].Element", "ReturnValue", "taint", "manual"]
- ["System.Text", "StringBuilder", False, "ToString", "(System.Int32,System.Int32)", "", "Argument[this].Element", "ReturnValue", "taint", "manual"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two need to use "Argument[this]" instead of "Argument[this].Element".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.

@tamasvajk tamasvajk added the no-change-note-required This PR does not need a change note label Dec 7, 2023
hvitved
hvitved previously approved these changes Dec 7, 2023
View reviewed changes
@tamasvajk tamasvajk merged commit 3431fcf into github:main Dec 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasvajk @hvitved