C#: Support interpolated strings in StringBuilder.Append
#15010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
commented
Dec 6, 2023
Click to show differences in coveragecsharpGenerated file changes for csharp
- System,"``System.*``, ``System``",25,11890,67,9
+ System,"``System.*``, ``System``",25,11900,67,9
- Totals,,25,13008,399,9
+ Totals,,25,13018,399,9
- System,67,25,11890,,8,8,9,,,4,5,33,1,17,3,4,9946,1944
+ System,67,25,11900,,8,8,9,,,4,5,33,1,17,3,4,9952,1948 |
tamasvajk
changed the title
StringBuilder.AppendStringBuilder.Append
tamasvajk
force-pushed
the
fix/stringbuilder-interpolation
branch
from
711325f to
0a42b3c
Compare
tamasvajk
force-pushed
the
fix/stringbuilder-interpolation
branch
from
0a42b3c to
e0c9be3
Compare
hvitved
requested changes
Dec 7, 2023
| - ["System.Text", "StringBuilder", False, "Append", "(System.UInt16)", "", "Argument[this]", "ReturnValue", "value", "manual"] | ||
| - ["System.Text", "StringBuilder", False, "Append", "(System.UInt32)", "", "Argument[this]", "ReturnValue", "value", "manual"] | ||
| - ["System.Text", "StringBuilder", False, "Append", "(System.UInt64)", "", "Argument[this]", "ReturnValue", "value", "manual"] | ||
| - ["System.Text", "StringBuilder", False, "Append", "(System.Text.StringBuilder+AppendInterpolatedStringHandler)", "", "Argument[0]", "ReturnValue", "taint", "manual"] |
There was a problem hiding this comment.
Should be
"Argument[this]", "ReturnValue"
There was a problem hiding this comment.
Thanks, I made these changes, also marked them as value steps
| - ["System.Text", "StringBuilder", False, "Append", "(System.UInt16)", "", "Argument[this]", "ReturnValue", "value", "manual"] | ||
| - ["System.Text", "StringBuilder", False, "Append", "(System.UInt32)", "", "Argument[this]", "ReturnValue", "value", "manual"] | ||
| - ["System.Text", "StringBuilder", False, "Append", "(System.UInt64)", "", "Argument[this]", "ReturnValue", "value", "manual"] | ||
| - ["System.Text", "StringBuilder", False, "Append", "(System.Text.StringBuilder+AppendInterpolatedStringHandler)", "", "Argument[0]", "ReturnValue", "taint", "manual"] | ||
| - ["System.Text", "StringBuilder", False, "Append", "(System.Text.StringBuilder+AppendInterpolatedStringHandler)", "", "Argument[0]", "Argument[this]", "taint", "manual"] | ||
| - ["System.Text", "StringBuilder", False, "Append", "(System.IFormatProvider,System.Text.StringBuilder+AppendInterpolatedStringHandler)", "", "Argument[1]", "ReturnValue", "taint", "manual"] |
There was a problem hiding this comment.
Should be
"Argument[this]", "ReturnValue"
| @@ -97,6 +103,10 @@ extensions: | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "()", "", "Argument[this]", "ReturnValue", "value", "manual"] | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "(System.String)", "", "Argument[0]", "Argument[this]", "taint", "manual"] | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "(System.String)", "", "Argument[this]", "ReturnValue", "value", "manual"] | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "(System.Text.StringBuilder+AppendInterpolatedStringHandler)", "", "Argument[0]", "ReturnValue", "taint", "manual"] | |||
There was a problem hiding this comment.
Should be
"Argument[this]", "ReturnValue"
| @@ -97,6 +103,10 @@ extensions: | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "()", "", "Argument[this]", "ReturnValue", "value", "manual"] | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "(System.String)", "", "Argument[0]", "Argument[this]", "taint", "manual"] | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "(System.String)", "", "Argument[this]", "ReturnValue", "value", "manual"] | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "(System.Text.StringBuilder+AppendInterpolatedStringHandler)", "", "Argument[0]", "ReturnValue", "taint", "manual"] | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "(System.Text.StringBuilder+AppendInterpolatedStringHandler)", "", "Argument[0]", "Argument[this]", "taint", "manual"] | |||
| - ["System.Text", "StringBuilder", False, "AppendLine", "(System.IFormatProvider,System.Text.StringBuilder+AppendInterpolatedStringHandler)", "", "Argument[1]", "ReturnValue", "taint", "manual"] | |||
There was a problem hiding this comment.
Should be
"Argument[this]", "ReturnValue"
hvitved
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves taint tracking in the
StringBuilderclass.StringBuilder.AppendandAppendLineimplements the special interpolated string handler pattern, which was previously not covered by our dataflow models. The PR adds a couple of missing dataflow summaries and extends the local taint tracking logic to handle the AST structure produced by the compiler.Commit-by-commit review is suggested, the first commits only move existing and add new test cases.
This PR depends on the previously merged changes:
StringBuilderflow models to not useElementaccess path #15025