C++/Java: Share core range analysis #14588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+781
to
+783
| if semNegative(x) | ||
| then upper = false and delta = D::fromInt(0) | ||
| else none() |
Check warning
Code scanning / CodeQL
Use of 'if' with a 'none()' branch. Warning
cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/SignAnalysisCommon.qll
Fixed
Show fixed
Hide fixed
cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/SignAnalysisCommon.qll
Fixed
Show fixed
Hide fixed
| bestBound(e, b, delta, upper) | ||
| module Sem implements Semantic { | ||
| private import java as J | ||
| private import SSA as SSA |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
|
DCA looks good. |
|
I intend to postpone qldoc fixes until I've done some more refactoring. And I also don't want to fix the two remaining ql4ql alerts. |
MathiasVP
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the core part of range analysis to be shared between C++ and Java. Properly sharing the surrounding support files and further cleanup is left as followup work, as this PR should make sense to merge on its own.
Commit-by-commit review is highly encouraged.
The initial alignment between the two implementations has resulted in a number of minor bug fixes and feature tweaks.
java/constant-comparison).