Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Fix modulus analysis. #14413

Closed
wants to merge 1 commit into from
Closed

C++: Fix modulus analysis. #14413

wants to merge 1 commit into from

Conversation

aschackmull
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the C++ label Oct 9, 2023
@MathiasVP
Copy link
Contributor

This removes about ~30 (out of ~7000) results on MRVA, and so far it looks like they're all fixed FPs 🎉. A few examples of where we no longer raise an alert:

@aschackmull aschackmull mentioned this pull request Oct 25, 2023
Merged
@aschackmull
Copy link
Contributor Author

Superseeded and implemented properly by #14588

@aschackmull aschackmull deleted the tmp/cpp-modulus branch October 27, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschackmull @MathiasVP