JS: Remove reference to deprecated step relation that's empty anyway

github · Dec 16, 2024 · 947b785 · 947b785
1 parent 0b2914f
commit 947b785
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 5 deletions.
diff --git a/...ib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataCustomizations.qll b/...ib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataCustomizations.qll
@@ -252,7 +252,6 @@ module ExternalApiUsedWithUntrustedData {
       |
         TaintTracking::sharedTaintStep(arg, _) or
         DataFlow::SharedFlowStep::step(arg, _) or
-        DataFlow::SharedFlowStep::step(arg, _, _, _) or
         DataFlow::SharedFlowStep::loadStep(arg, _, _) or
         DataFlow::SharedFlowStep::storeStep(arg, _, _) or
         DataFlow::SharedFlowStep::loadStoreStep(arg, _, _)

diff --git a/javascript/ql/src/meta/analysis-quality/TaintSteps.ql b/javascript/ql/src/meta/analysis-quality/TaintSteps.ql
@@ -17,8 +17,6 @@ predicate relevantStep(DataFlow::Node pred, DataFlow::Node succ) {
     or
     DataFlow::SharedFlowStep::step(pred, succ)
     or
-    DataFlow::SharedFlowStep::step(pred, succ, _, _)
-    or
     DataFlow::SharedFlowStep::loadStep(pred, succ, _)
     or
     DataFlow::SharedFlowStep::storeStep(pred, succ, _)

diff --git a/javascript/ql/src/meta/analysis-quality/UnmodelledSteps.ql b/javascript/ql/src/meta/analysis-quality/UnmodelledSteps.ql
@@ -24,8 +24,6 @@ predicate unmodeled(API::Node callee, API::CallNode call, DataFlow::Node pred, D
     or
     DataFlow::SharedFlowStep::step(_, succ)
     or
-    DataFlow::SharedFlowStep::step(_, succ, _, _)
-    or
     DataFlow::SharedFlowStep::loadStep(_, succ, _)
     or
     DataFlow::SharedFlowStep::storeStep(_, succ, _)