JS: A few more deprecation updates

github · Dec 16, 2024 · 0b2914f · 0b2914f
1 parent db00dad
commit 0b2914f
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/BuildArtifactLeakCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/BuildArtifactLeakCustomizations.qll
@@ -14,9 +14,11 @@ module BuildArtifactLeak {
    */
   abstract class Sink extends DataFlow::Node {
     /**
+     * DEPRECATED. This query no longer uses flow state.
+     *
      * Gets a data-flow label that leaks information for this sink.
      */
-    DataFlow::FlowLabel getLabel() { result.isTaint() }
+    deprecated DataFlow::FlowLabel getLabel() { result.isTaint() }
   }
 
   /**

diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/InsecureDownloadCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/InsecureDownloadCustomizations.qll
@@ -88,7 +88,7 @@ module InsecureDownload {
   /**
    * Flow-labels for reasoning about download of sensitive file through insecure connection.
    */
-  module Label {
+  deprecated module Label {
     /**
      * A flow-label for file URLs that are both sensitive and downloaded over an insecure connection.
      */

diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/PostMessageStarCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/PostMessageStarCustomizations.qll
@@ -24,16 +24,20 @@ module PostMessageStar {
   abstract class Sanitizer extends DataFlow::Node { }
 
   /**
+   * DEPRECATED. This query no longer uses flow state.
+   *
    * A flow label representing an object with at least one tainted property.
    */
-  abstract class PartiallyTaintedObject extends DataFlow::FlowLabel {
+  abstract deprecated class PartiallyTaintedObject extends DataFlow::FlowLabel {
     PartiallyTaintedObject() { this = "partially tainted object" }
   }
 
   /**
+   * DEPRECATED. This query no longer uses flow state.
+   *
    * Gets either a standard flow label or the partial-taint label.
    */
-  DataFlow::FlowLabel anyLabel() {
+  deprecated DataFlow::FlowLabel anyLabel() {
     result.isDataOrTaint() or result instanceof PartiallyTaintedObject
   }
 

diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeDynamicMethodAccessQuery.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeDynamicMethodAccessQuery.qll
@@ -9,7 +9,6 @@
 
 import javascript
 import PropertyInjectionShared
-private import DataFlow::FlowLabel
 import UnsafeDynamicMethodAccessCustomizations::UnsafeDynamicMethodAccess
 private import UnsafeDynamicMethodAccessCustomizations::UnsafeDynamicMethodAccess as UnsafeDynamicMethodAccess
 

diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeJQueryPluginCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeJQueryPluginCustomizations.qll
@@ -9,8 +9,6 @@ private import semmle.javascript.dataflow.InferredTypes
 import semmle.javascript.security.dataflow.DomBasedXssCustomizations
 
 module UnsafeJQueryPlugin {
-  private import DataFlow::FlowLabel
-
   /**
    * A data flow source for unsafe jQuery plugins.
    */