Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-1121: compare slider support for COGtiffs #1122

Merged
merged 5 commits into from
Nov 18, 2024
Merged

PB-1121: compare slider support for COGtiffs #1122

merged 5 commits into from
Nov 18, 2024

Commits on Nov 18, 2024

  1. PB-1121: compare slider support for COGtiffs 

    Issue : COGTiffs are rendered as a webGL layer, which has a different graphical context than other OpenLayers layers. This causes the compare slider to not work on them.

Fix : when we deal with a COGtiff layer, we instead use the webgl context tools to make the slice.
    @ltkum
    ltkum committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1b47c0a View commit details
    Browse the repository at this point in the history

  2. PB-1121: Compare slider for COGTIFFS 

    - refactored the slicing mechanism to reduce the number of event assignations
- we clear the webGL context before rendering, to avoid artifacts
- we set the id directly in the COGTIFF layer
    @ltkum
    ltkum committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5f40f0e View commit details
    Browse the repository at this point in the history

  3. PB-1121: PR fixes

    @ltkum
    ltkum committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c02e118 View commit details
    Browse the repository at this point in the history

  4. PB-1121: compare slider works with COG imported through menus 

    - Issue : When importing through the menu, the watchers in the compare slider caught the layer on top being modified before the layer was added to the OpenLayers Map object itself
- Fix : when importing through the menu, we now send a signal that we should force a compare slider update once the import is finished
    @ltkum
    ltkum committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    dc169f0 View commit details
    Browse the repository at this point in the history

  5. PB-1121: using pre compose event to handle COG slider 

    Issue : When importing or toggling visibility on WebGL layers, the layerconfig was updated before the map, and the new layer would not have the prerender and postrender events set.

Fix : OpenLayers Map fire precompose events when webGL layers are involved. This allows us to add a precompose event on the map to add the prerender events just before the first rendering is supposed to happen.
    @ltkum
    ltkum committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5779d5f View commit details
    Browse the repository at this point in the history