PB-1121: compare slider support for COGtiffs #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1121-support-compare-slider-for-COGTIFFs
|
| Run status |
|
| Run duration | 05m 13s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
212
|
| View all changes introduced in this branch ↗︎ | |
ltkum
force-pushed
the
fix-PB-1121-support-compare-slider-for-COGTIFFs
branch
2 times, most recently
from
cc06929
to
087aec6
Compare
pakb
reviewed
Nov 15, 2024
ltkum
force-pushed
the
fix-PB-1121-support-compare-slider-for-COGTIFFs
branch
from
a99adc1
to
5e9770d
Compare
ltkum
force-pushed
the
fix-PB-1121-support-compare-slider-for-COGTIFFs
branch
from
5e9770d
to
f96b7fc
Compare
|
If you load (import) https://data.geo.admin.ch/ch.swisstopo.rapidmapping/data/2024-012-MISOX/RM_2024_MISOX_DOPmosaic_25cm_20240628_RGB8BIT_LV95_COG.tif while the compare slider is active, the newly created layer isn't cut. |
Sure |
ltkum
force-pushed
the
fix-PB-1121-support-compare-slider-for-COGTIFFs
branch
from
1041d06
to
cae50e8
Compare
pakb
approved these changes
Nov 18, 2024
Issue : COGTiffs are rendered as a webGL layer, which has a different graphical context than other OpenLayers layers. This causes the compare slider to not work on them. Fix : when we deal with a COGtiff layer, we instead use the webgl context tools to make the slice.
- refactored the slicing mechanism to reduce the number of event assignations - we clear the webGL context before rendering, to avoid artifacts - we set the id directly in the COGTIFF layer
- Issue : When importing through the menu, the watchers in the compare slider caught the layer on top being modified before the layer was added to the OpenLayers Map object itself - Fix : when importing through the menu, we now send a signal that we should force a compare slider update once the import is finished
Issue : When importing or toggling visibility on WebGL layers, the layerconfig was updated before the map, and the new layer would not have the prerender and postrender events set. Fix : OpenLayers Map fire precompose events when webGL layers are involved. This allows us to add a precompose event on the map to add the prerender events just before the first rendering is supposed to happen.
ltkum
force-pushed
the
fix-PB-1121-support-compare-slider-for-COGTIFFs
branch
from
5fea931
to
5779d5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : COGTiffs are rendered as a webGL layer, which has a different graphical context than other OpenLayers layers. This causes the compare slider to not work on them.
Fix : when we deal with a COGtiff layer, we instead use the webgl context tools to make the slice.
Test link