Install gz-sim*-cli on ros_gz testing builds #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
azeey
reviewed
Sep 1, 2023
| @@ -30,6 +30,10 @@ fi | |||
| echo '# END SECTION' | |||
|
|
|||
| echo '# BEGIN SECTION: test gz_sim via ros2 launch' | |||
| # Workaround until ros_gz defines a dependency on gz-sim*-cli. Avoid to use | |||
| # apt --install-suggests since it installs the whole universe of packages | |||
| VER=\$(dpkg -l | grep libgz-sim | grep ^ii | head -1 | awk '{ print \$3 '}) | |||
There was a problem hiding this comment.
Not sure why there's a \$ instead of $ and in the awk '{ print \$3 '}, should the ' be after }?
There was a problem hiding this comment.
Not sure why there's a $ instead of $
An extra \ is needed since we are in a bash """ block that is going to be consumed by bash, if we don't use that this will be translated to a bash variable instead of reaching the real execution as pure $3.
awk '{ print $3 '}, should the ' be after }?
Umm this indeed seems a bug that bash passed just fine. I change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ros_gz_simpackage for being able to run with ros launch needs to have thegz-sim*-clipackage. This is probably a bug inros_gzcode.Until we get that fixed, this PR adds automatically that package into the testing job so the smoke test can be run.
Tested: