Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attempt: CI #48

Merged
merged 12 commits into from
Nov 5, 2024
Merged

Fix attempt: CI #48

merged 12 commits into from
Nov 5, 2024

Conversation

thedevbirb
Copy link
Contributor

@thedevbirb thedevbirb commented Nov 4, 2024

This PR is a best attempt to fix the current CI flow. Does so with the following steps:

  • re-adding rust-toolchain.toml file (removed by f9e2fe8)
  • formatting the codebase using the nightly-2023-06-01 toolchain
  • solve clippy errors
  • expose useful commands for CI checks in a justfile
  • updating CI workflows to add postgres and redis service in order to use them for the appropriate tests
  • fix some of the existing tests
  • marking failing tests that are not trivially fixable by adding #[ignore = "TODO: to fix"].

The last step is a very opinionated approach but I think it's helpful in order to have insights on which new commits are breaking previously passing tests. The tests that have been marked in this way can be tracked with an issue.

All steps have been carried in atomic commits -- I suggest to look at the PR commit by commit and if you don't agree with some of the choices above mentioned I can simply drop some of them.

@0w3n-d 0w3n-d merged commit 4aace5f into gattaca-com:develop Nov 5, 2024
2 of 3 checks passed
@thedevbirb thedevbirb deleted the lore/fix/ci branch November 5, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants