-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce max_block_value_to_verify in constraints config #23
introduce max_block_value_to_verify in constraints config #23
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Here are some minor changes that should be done in our opinion.
Once you've done these, can you run just fmt
and make sure just fmt-check
and just clippy
introduced in gattaca-com#48 run without errors?
- fix lints + other refactoring - max_block_value_to_verify_wei now U256 to handle big value cases - return earlier in get_header_with_proofs call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on the devnet and works good, a minor change is needed to make tests compile.
max_block_value_to_verify
submit_block
andget_header_with_proofs
Reasoning behind this is that we don't want validators to miss out on big ETH rewards on mainnet while testing inclusion preconf blocks.